Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: revert pr/35975, do not reduce concurrency for keep order coprocessor request (#55141) #55155

Merged
merged 1 commit into from
Aug 2, 2024
Merged

store/copr: revert pr/35975, do not reduce concurrency for keep order coprocessor request (#55141) #55155

merged 1 commit into from
Aug 2, 2024

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #54969

Problem Summary:

What changed and how does it work?

Cherry-pick #55141 to provide a hotfix on v7.1

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2024
@tiprow tiprow
Copy link

tiprow bot commented Aug 2, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 2, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.1-20240802-v7.1.5@caa60c0). Learn more about missing BASE report.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-7.1-20240802-v7.1.5     #55155   +/-   ##
================================================================
  Coverage                               ?   73.4308%           
================================================================
  Files                                  ?       1211           
  Lines                                  ?     380106           
  Branches                               ?          0           
================================================================
  Hits                                   ?     279115           
  Misses                                 ?      83164           
  Partials                               ?      17827

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-02 06:19:06.574681871 +0000 UTC m=+70343.793443464: ☑️ agreed by lcwangchao.
  • 2024-08-02 06:45:07.341750485 +0000 UTC m=+71904.560512089: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit c1456c5 into pingcap:release-7.1-20240802-v7.1.5 Aug 2, 2024
9 checks passed
@tiancaiamao tiancaiamao deleted the cherry-pick branch August 5, 2024 09:58
@tiancaiamao tiancaiamao mentioned this pull request Aug 5, 2024
Merged
13 tasks
This was referenced Aug 6, 2024
Merged
Open
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiancaiamao @lcwangchao @Defined2014